-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #11951] Fix the problem that the servicename and groupname are not resolved correctly when deleting an empty service instance #11955
Conversation
…emented by default in Nacos is one more than the actual number of connections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help community to add unit test for this case?
It seems that a unit test already exists here:ServiceControllerTest |
Yes I know it, I mean the old one only check the UpdateServiceTraceEvent , not check DeregisterServiceTraceEvent |
Prefer you add the check for DeregisterServiceTraceEvent in UT. |
I'm sorry I didn't understand how to write unit tests for Nacos. Do you mean to change it to this?
|
Bug fix #11951 修改删除空服务实例时,服务名和分组名没有正确解析的问题