-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE#11910] resolve mapper class paging parameter problem #11915
base: develop
Are you sure you want to change the base?
Conversation
Some paginated queries seem to require the helper. fetchPageLimit method instead of the original helper. fetchPage method ,Is it possible to modify it this way? @KomachiSion |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11915 +/- ##
=============================================
- Coverage 68.63% 68.63% -0.01%
- Complexity 9034 9036 +2
=============================================
Files 1239 1239
Lines 40610 40606 -4
Branches 4317 4317
=============================================
- Hits 27872 27869 -3
+ Misses 10746 10745 -1
Partials 1992 1992
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should do more understand for nacos database plugin.
...s/config/server/service/repository/embedded/EmbeddedHistoryConfigInfoPersistServiceImpl.java
Show resolved
Hide resolved
.../config/server/service/repository/embedded/EmbeddedConfigInfoAggrPersistServiceImplTest.java
Outdated
Show resolved
Hide resolved
paramList.add(tenantId); | ||
final String sqlCount = "SELECT count(*) FROM config_info_aggr WHERE data_id=? AND group_id=? AND tenant_id=?"; | ||
return new MapperResult(sqlCount, paramList); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这么改似乎目前不会影响用户自定义的插件逻辑,相当于还是一种固定参数的形式。针对分页提供了count的默认实现方法,如果用户想实现自己的count逻辑也可以重写默认实现方法。相当于用户自己实现的数据源插件,count查询提供了入口进行修改。看这么改是否合适;可以review一下我最新一次的提交 @KomachiSion
I see the new changes, But I think no much different with the old one, or the change files is so many that I can't get the key change points. |
|
|
Can you have time to reply to me @KomachiSion |
抱歉, 这个issue 暂时先block吧, 感觉改动有一点大。 |
link #11910