Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UT for control default plugin #11572

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

godhth
Copy link
Contributor

@godhth godhth commented Dec 28, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

link #4981

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (526227c) 63.87% compared to head (f83b962) 64.01%.
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11572      +/-   ##
=============================================
+ Coverage      63.87%   64.01%   +0.13%     
- Complexity      7076     7086      +10     
=============================================
  Files           1066     1066              
  Lines          31580    31611      +31     
  Branches        3233     3235       +2     
=============================================
+ Hits           20171    20235      +64     
+ Misses         10143    10108      -35     
- Partials        1266     1268       +2     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 526227c...f83b962. Read the comment docs.

@Hhendra32
Copy link

login

@KomachiSion KomachiSion merged commit 2296125 into alibaba:develop Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants