-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix config test case and remove useless code #11521
Merged
KomachiSion
merged 12 commits into
alibaba:develop
from
shiyiyue1102:develop-fixtestcase
Dec 18, 2023
Merged
fix config test case and remove useless code #11521
KomachiSion
merged 12 commits into
alibaba:develop
from
shiyiyue1102:develop-fixtestcase
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # config/src/test/java/com/alibaba/nacos/config/server/controller/ConfigServletInnerTest.java # config/src/test/java/com/alibaba/nacos/config/server/remote/ConfigPublishRequestHandlerTest.java # core/src/test/java/com/alibaba/nacos/core/remote/grpc/GrpcConnectionTest.java
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #11521 +/- ##
==========================================
Coverage 62.14% 62.14%
- Complexity 6918 6919 +1
==========================================
Files 1066 1066
Lines 31656 31656
Branches 3253 3253
==========================================
Hits 19673 19673
Misses 10652 10652
Partials 1331 1331 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
KomachiSion
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix config test case and remove useless code## Brief changelog
[ISSUE #11520 ]