Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUES #11499] fix address server health check error #11508

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Dec 13, 2023

Close #11499

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

return UP status when the nacos server doesn't use address-server

Brief changelog

optimize HealthController#isAddressServerHealthy logic

Verifying this change

  1. start nacos server using the standalone model
  2. curl http://localhost:8848/nacos/v1/cs/health
  3. check api result

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some unit test for this cases?

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Merging #11508 (b0bcf64) into develop (5880368) will increase coverage by 0.19%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11508      +/-   ##
=============================================
+ Coverage      61.53%   61.73%   +0.19%     
- Complexity      6831     6859      +28     
=============================================
  Files           1066     1066              
  Lines          31599    31645      +46     
  Branches        3251     3257       +6     
=============================================
+ Hits           19445    19535      +90     
+ Misses         10805    10759      -46     
- Partials        1349     1351       +2     

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5880368...b0bcf64. Read the comment docs.

@onewe
Copy link
Collaborator Author

onewe commented Dec 15, 2023

done

@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Dec 19, 2023
@KomachiSion KomachiSion added this to the 2.3.1 milestone Dec 19, 2023
@KomachiSion KomachiSion merged commit d40190e into alibaba:develop Dec 19, 2023
7 checks passed
@onewe onewe deleted the issues/11499 branch December 19, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

未使用address-server lookup时health接口返回响应'DOWN:address server down'
3 participants