add startup conditions #11305
Merged
add startup conditions #11305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #11305 +/- ##
=============================================
- Coverage 58.42% 58.33% -0.09%
- Complexity 5752 5754 +2
=============================================
Files 885 885
Lines 27356 27356
Branches 2890 2890
=============================================
- Hits 15982 15959 -23
- Misses 10156 10179 +23
Partials 1218 1218 see 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
KomachiSion
requested changes
Oct 30, 2023
|
我看了一下错误， 可能是UT顺序问题导致的， 解决方法应该是mockEnv，而不是去启动spring context。 可以参考DistroModuleStateBuilderTest等也依赖Env的UT是如何做的。 另外，为了保证不影响其他的UT，最好在After中清理掉这个TlsConfig的instance |
|
好， 那后面我参考DistroModuleStateBuilderTest 做出一些响应的修改， 多谢大佬将问题指出。
。
***@***.***
…------------------ 原始邮件 ------------------
发件人: "杨翊 ***@***.***>;
发送时间: 2023年10月30日(星期一) 下午4:42
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [alibaba/nacos] add startup conditions (PR #11305)
我看了一下错误， 可能是UT顺序问题导致的， 解决方法应该是mockEnv，而不是去启动spring context。
可以参考DistroModuleStateBuilderTest等也依赖Env的UT是如何做的。
另外，为了保证不影响其他的UT，最好在After中清理掉这个TlsConfig的instance
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
KomachiSion
approved these changes
Nov 1, 2023
lowezheng
added a commit
to lowezheng/nacos
that referenced
this pull request
Nov 12, 2023
* develop: (137 commits) Develop refactor topn (alibaba#11352) Develop fill ut common (alibaba#11335) Optimize MapperManager (alibaba#11195) Simplify the validate method for serviceinfo (alibaba#11312) add startup conditions (alibaba#11305) Fix some typos (alibaba#11269) fix: rename tar name (alibaba#11281) 优化节点显示，添加mode (alibaba#11275) [ISSUE alibaba#11253]To fix the triggering of the listener upon failover con… (alibaba#11254) Add description for new plugin. (alibaba#11268) Upgrade to 2.3.0-BETA. (alibaba#11262) [ISSUE alibaba#11255]Update PathEncoderManagerTest#testEncodeWithNonExistOs. (alibaba#11256) Fill ut for common module (alibaba#11247) Optimize ThreadPoolManager (alibaba#11206) Fix npe when setup ack response in GrpcClient (alibaba#11210) [ISSUE#11192] batchRegisterInstance add recalculateRevision (alibaba#11232) feat(alibaba#11236): Remove invalid assertion in com.alibaba.nacos.config.server.service.ConfigCacheService#dumpChange. (alibaba#11237) feat(11115): http support cas publish. (alibaba#11120) [ISSUE alibaba#11231]Optimize the handleSpringBinder method in PropertiesUtil. (alibaba#11240) ISSUE alibaba#11212 (alibaba#11213) ... # Conflicts: # console-ui/package-lock.json # console-ui/package.json # console-ui/src/pages/Login/Login.jsx # core/src/main/java/com/alibaba/nacos/core/listener/StartingApplicationListener.java # pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
#11304
XXXXX