Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10797]Enhance the registration logic. #11228

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

stone-98
Copy link
Contributor

@stone-98 stone-98 commented Oct 7, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

In the RecAbilityContext class, the await method now returns a value indicating whether a response from the server has been received. Upon receiving a server response, it is considered successful; otherwise, it is regarded as a registration failure.

Brief changelog

For #10797

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #11228 (0ba1817) into develop (f3fb428) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11228      +/-   ##
=============================================
- Coverage      54.12%   54.04%   -0.09%     
  Complexity      5580     5580              
=============================================
  Files            907      907              
  Lines          28840    28844       +4     
  Branches        3190     3191       +1     
=============================================
- Hits           15610    15588      -22     
- Misses         11886    11915      +29     
+ Partials        1344     1341       -3     
Files Coverage Δ
...ba/nacos/common/remote/client/grpc/GrpcClient.java 15.13% <0.00%> (-0.29%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3fb428...0ba1817. Read the comment docs.

@KomachiSion KomachiSion merged commit 1c7b9b9 into alibaba:develop Oct 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants