Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUES #10014] clear confused logic about namespace properties #10023

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Mar 1, 2023

Close #10014

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@onewe onewe requested a review from KomachiSion March 1, 2023 03:05
Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能不是直接移除, 按照原逻辑, 应该是希望先从ENV/JVM中取, 取不到最后再从用户设置中取,

也就是这个地方不能按照默认的properties search逻辑走。

如果要改成properties search逻辑,会改变原逻辑,需要单独看一下。

@onewe
Copy link
Collaborator Author

onewe commented Mar 2, 2023

好, 我对比一下以前的代码 看看

- add getPropertyFrom method
- optimize some code logic

Close alibaba#10014
@KomachiSion KomachiSion merged commit f969595 into alibaba:develop Mar 9, 2023
@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/bug Category issues or prs related to bug. labels Mar 9, 2023
@KomachiSion KomachiSion added this to the 2.2.1 milestone Mar 9, 2023
@onewe onewe deleted the issues/10014 branch March 9, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confuse logic?
2 participants