Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distro data load time out cannot be configured #8594

Closed
liqipeng opened this issue Jun 19, 2022 · 2 comments
Closed

Distro data load time out cannot be configured #8594

liqipeng opened this issue Jun 19, 2022 · 2 comments
Labels
kind/enhancement Category issues or prs related to enhancement. status/need discuss
Milestone
2.1.1

Comments

@liqipeng
Copy link
Contributor

The default data load time out is 3000 ms. When the instances quantity increase, the snapshot api will cost more time.
So it's better to make the time out can be configured.
@liqipeng liqipeng mentioned this issue Jun 19, 2022
Merged
@KomachiSion
Copy link
Collaborator

default 3000ms may be is too low, snapshot may be large size, I think default can set 30000ms.

@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. status/need discuss labels Jun 20, 2022
@liqipeng
Copy link
Contributor Author

default 3000ms may be is too low, snapshot may be large size, I think default can set 30000ms.

ok

KomachiSion pushed a commit that referenced this issue Jun 24, 2022
@liqipeng
[ISSUE #8594] makes distro data load timeout can be configured. (#8595)
f3d134d 
* makes distro data load timeout can be configured.

* specify nacos.core.protocol.distro.data.load.timeoutMs default 30s
@KomachiSion KomachiSion added this to the 2.1.1 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement. status/need discuss
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
2 participants
@liqipeng @KomachiSion