Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method of checking ip address is Error #8208

Closed
qiugongzi opened this issue Apr 19, 2022 · 4 comments · Fixed by #8210
Closed

Method of checking ip address is Error #8208

qiugongzi opened this issue Apr 19, 2022 · 4 comments · Fixed by #8210
Labels
area/Naming kind/bug Category issues or prs related to bug.

Comments

@qiugongzi
Copy link
Contributor

qiugongzi commented Apr 19, 2022

Describe the bug
image

it makes no sense to check ipAddress like this.
if I pass by "192.168.1.3d" as ip , this check will pass by.
so it wouldn't promise the correctness of ip

Expected behavior
check ip

Acutally behavior
makes no sense

How to Reproduce
Steps to reproduce the behavior:

  1. Rewrite a method that checks ip including ipv4 or ipv6

Desktop (please complete the following information):

  • OS: [e.g. Centos]
  • Version [e.g. nacos-server 1.3.1, nacos-client 1.3.1]
  • Module [e.g. naming/config]
  • SDK [e.g. original, spring-cloud-alibaba-nacos, dubbo]

Additional context
Add any other context about the problem here.

@onewe
Copy link
Collaborator

onewe commented Apr 20, 2022

It's been fixed already, update to latest version please!

@qiugongzi
Copy link
Contributor Author

It's been fixed already, update to latest version please!

Maybe I dont describe it clearly,however,I try it just now,it stills there. see https://github.com/alibaba/nacos/blob/develop/naming/src/main/java/com/alibaba/nacos/naming/core/Instance.java.

@onewe
Copy link
Collaborator

onewe commented Apr 20, 2022

I'm sorry, It's my fault, I will fix it. 😂

@onewe
Copy link
Collaborator

onewe commented Apr 20, 2022

@i will resolve it@

@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Naming labels Apr 20, 2022
onewe added a commit to onewe/nacos that referenced this issue Apr 20, 2022
KomachiSion pushed a commit that referenced this issue Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Naming kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants