-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method of checking ip address is Error #8208
Labels
Comments
It's been fixed already, update to latest version please! |
Maybe I dont describe it clearly,however,I try it just now,it stills there. see https://github.com/alibaba/nacos/blob/develop/naming/src/main/java/com/alibaba/nacos/naming/core/Instance.java. |
I'm sorry, It's my fault, I will fix it. 😂 |
@i will resolve it@ |
onewe
added a commit
to onewe/nacos
that referenced
this issue
Apr 20, 2022
KomachiSion
pushed a commit
that referenced
this issue
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
it makes no sense to check ipAddress like this.
if I pass by "192.168.1.3d" as ip , this check will pass by.
so it wouldn't promise the correctness of ip
Expected behavior
check ip
Acutally behavior
makes no sense
How to Reproduce
Steps to reproduce the behavior:
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: