Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant functional interfaces #6628

Closed
hunjipo opened this issue Aug 11, 2021 · 1 comment
Closed

Remove redundant functional interfaces #6628

hunjipo opened this issue Aug 11, 2021 · 1 comment

Comments

@hunjipo
Copy link
Contributor

hunjipo commented Aug 11, 2021

Is your feature request related to a problem? Please describe.
In nacos-common moudle, there are two functional interfaces is BiFunction and BiConsumer. They are all copied from jdk8 or Apache Commons. I guess these functional interfaces were created because nacos used a JDK version lower than 8, but we wanted to use functional interfaces. But now, nacos depends on the JDK version. The minimum requirement is 8. Therefore, we can delete these interfaces and use the interfaces provided by JDK.

Describe the solution you'd like

Can I mention a PR to delete these interfaces?

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.

@BlackBAKA
Copy link
Contributor

@i will solve it@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants