Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming client may register the old one instance when reconnecting to server. #5831

Closed
KomachiSion opened this issue May 24, 2021 · 0 comments · Fixed by #5832
Closed

Naming client may register the old one instance when reconnecting to server. #5831

KomachiSion opened this issue May 24, 2021 · 0 comments · Fixed by #5832
Assignees
Labels
kind/bug Category issues or prs related to bug. version/2.x
Milestone

Comments

@KomachiSion
Copy link
Collaborator

Describe the bug
Current client naming will cache all registered service and instance so that It can redo the registering when reconnection.

But for nacos 2.0 server, one client connection only can register one instance for one service. So cache more instance for same instance is useless and using set to cache will make it disorder and register error instance when reconnection.

Expected behavior
Redo register the last registered instance for service.

Acutally behavior
Maybe register the old registered instance for service.

Desktop (please complete the following information):

  • Version nacos-server 2.0.x, nacos-client 2.0.x
  • Module naming
  • SDK original

Additional context
If users keep registering the same service, the client might be OOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. version/2.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant