Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Quality] [nacos-config] [sub issue] improve the code quality of module nacos-config. #5727

Closed
brotherlu-xcq opened this issue May 14, 2021 · 0 comments · Fixed by #5729, #5730, #5731, #5732 or #5744
Closed

[Code Quality] [nacos-config] [sub issue] improve the code quality of module nacos-config. #5727

brotherlu-xcq opened this issue May 14, 2021 · 0 comments · Fixed by #5729, #5730, #5731, #5732 or #5744
Labels
kind/code quality

Comments

@brotherlu-xcq
Copy link
Collaborator

brotherlu-xcq commented May 14, 2021 •
edited
Loading

Description

Module: nacos-config

This issue is the sub issue of #5726 , it will improve the code quality of module nacos-config. we improve the code quality by directory.

the PR list

dirctory PR status
aspect #5730 merged
auth #5729 merged
controller #5731 merged
remote #5732 merged
service #5744 #5752 merged
utils #5761 merged
@brotherlu-xcq brotherlu-xcq mentioned this issue May 14, 2021
Closed
@brotherlu-xcq brotherlu-xcq changed the title [Code Quality] sub issue, improve the code quality of module nacos-config. [Code Quality] [nacos-config] [sub issue] improve the code quality of module nacos-config. May 14, 2021
This was referenced May 14, 2021
Merged
Merged
Merged
Merged
Merged
Merged
@KomachiSion KomachiSion reopened this May 17, 2021
KomachiSion pushed a commit that referenced this issue May 17, 2021
@brotherlu-xcq
[ISSUE #5727 service-2] improve the code quality of nacos-config (#5752)
7b912fe 
* [code quality] [nacos-config] [service-2] add change the position of variable to match common code habits , add the mission @OverRide, remove the unnesessary judgement.

* [code quality] [nacos-config] [service-2] indent problem fix
@KomachiSion KomachiSion reopened this May 17, 2021
@brotherlu-xcq brotherlu-xcq mentioned this issue May 17, 2021
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue May 18, 2021
@brotherlu-xcq
[ISSUE #5727 service-1] improve the code quality of nacos-config (#5744)
162b0ea 
* [code quality] [nacos-config] [service-1] add change the position of variable to match common code habits , return first, reduce the if/for nest, change the Chinese javadoc to English.

* [code quality] [nacos-config] [service-1] ci problem

* [code quality] [nacos-config] [service-1] ci problem

* [code quality] [nacos-config] [service-1] indent problem fix

* [code quality] [nacos-config] [service-1] indent problem
KomachiSion pushed a commit that referenced this issue May 18, 2021
@brotherlu-xcq
[ISSUE #5727 utils] improve the code quality of nacos-config (#5761)
8d927c1 
* [code quality] [nacos-config] [utils] the Chinese javadoc translate, return javadoc complete, the magic number fix, the code logic format

* [code quality] [nacos-config] [utils] fix space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/code quality
Projects
None yet
Milestone
No milestone
2 participants
@brotherlu-xcq @KomachiSion