Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for module nacos-consistency in nacos 2.0 #5093

Closed
realJackSun opened this issue Mar 12, 2021 · 1 comment · Fixed by #6490
Closed

Add unit tests for module nacos-consistency in nacos 2.0 #5093

realJackSun opened this issue Mar 12, 2021 · 1 comment · Fixed by #6490
Labels
area/Test

Comments

@realJackSun
Copy link
Collaborator

realJackSun commented Mar 12, 2021 •
edited
Loading

This is a sub-issue of [ISSUE #4981]
The nacos-consistency module coverage rate is too low, this ISSUE aims to adding more unit tests to nacos-consistency module.
@realJackSun realJackSun mentioned this issue Mar 12, 2021
Open
6 tasks
@realJackSun realJackSun changed the title Add unit tests for module nacos-consistency Add unit tests for module nacos-consistency in nacos 2.0 Mar 12, 2021
@haoyann
Copy link
Collaborator

haoyann commented Apr 4, 2021

I will solve this.

brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 28, 2021
@brotherlu-xcq
[ISSUE alibaba#5093] add unit test in nacos-consistency.
1b47f0e
@brotherlu-xcq brotherlu-xcq mentioned this issue Jul 28, 2021
Merged
5 tasks
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 28, 2021
@brotherlu-xcq
Merge branch 'develop' of https://github.com/brotherlu-xcq/nacos into…
78ea3d2 
… fix-alibaba#5093
KomachiSion pushed a commit that referenced this issue Jul 29, 2021
@brotherlu-xcq
[ISSUE #5093] Add unit tests for module nacos-consistency in nacos 2.…
8f6bf61 
…0. (#6490)

* [ISSUE #5093] add unit test in nacos-consistency.

* fix unit test which cannot pass ci.

* remove the unused import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #5093] Add unit tests for module nacos-consistency in nacos 2.0. brotherlu-xcq/nacos
3 participants
@KomachiSion @haoyann @realJackSun