Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Com. Alibaba. Nacos. Sys. File. WatchFileCenter# registerWatcher registerWatcher methods recorded in the WATCH the number of jobs is the actual number of recorded call registerWatcher method #4415

Closed
haojiawei111 opened this issue Dec 6, 2020 · 2 comments · Fixed by #4469
Closed

Com. Alibaba. Nacos. Sys. File. WatchFileCenter# registerWatcher registerWatcher methods recorded in the WATCH the number of jobs is the actual number of recorded call registerWatcher method #4415

haojiawei111 opened this issue Dec 6, 2020 · 2 comments · Fixed by #4469
Assignees
@chuntaojun
Labels
contribution welcome kind/bug Category issues or prs related to bug.

Comments

@haojiawei111
Copy link

haojiawei111 commented Dec 6, 2020 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.
Com. Alibaba. Nacos. Sys. File. WatchFileCenter# registerWatcher
The NOW_WATCH_JOB_CNT variable in method registerWatcher actually records the number of watchdirjobs or the number of FileWatcher, but NOW_WATCH_JOB_CNT currently records the number of calls to method registerWatcher.
This is not consistent with the original intent of creating the NOW_WATCH_JOB_CNT variable.
图片

Expected behavior
The NOW_WATCH_JOB_CNT variable should be added one when putting WatchDirJob or when calling addSubscribe
@chuntaojun chuntaojun added kind/bug Category issues or prs related to bug. contribution welcome labels Dec 6, 2020
@chuntaojun
Copy link
Collaborator

Welcome to contribute to the solution

@haoyann
Copy link
Collaborator

haoyann commented Dec 11, 2020

@i will sove it@

This was referenced Dec 12, 2020
Closed
Merged
chuntaojun added a commit that referenced this issue Dec 13, 2020
@chuntaojun
Merge pull request #4469 from haoyann/fix-4415
19a04bf 
[ISSUE #4415] fix NOW_WATCH_JOB_CNT record WatchDirJob count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuntaojun chuntaojun

Labels
contribution welcome kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4415] fix NOW_WATCH_JOB_CNT record WatchDirJob count haoyann/nacos
3 participants
@chuntaojun @haojiawei111 @haoyann