Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports modifying part of the key-value of the instance metadata #3904

Closed
chuntaojun opened this issue Sep 23, 2020 · 1 comment
Closed
Labels
contribution welcome kind/discussion Category issues related to discussion kind/feature type/feature
Milestone

Comments

@chuntaojun
Copy link
Collaborator

chuntaojun commented Sep 23, 2020

Is your feature request related to a problem? Please describe.

The interface can be provided to support the modification of the value corresponding to several keys of the instance metadata

Describe the solution you'd like

updateInstanceMatadata(instance unique key, Map<string, string> newSubMetadataVal)

batchUpdateInstanceMatadata(List<instance unique key, Map<string, string> newSubMetadataVal>)

removeInstanceMetadata(instance unique key, wait remove keys)

batchRemoveInstanceMetadata(List<instance unique key, wait remove keys>)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@chuntaojun chuntaojun added contribution welcome kind/discussion Category issues related to discussion kind/feature type/feature labels Sep 23, 2020
@horizonzy
Copy link
Collaborator

ok. @i will solve it@

KomachiSion pushed a commit that referenced this issue Oct 19, 2020
* feature. add update and delete operation on instance's metadata 90%

* 1.add unit test
2.fix-locateInstance error

* format code style

* add @link on class

* move metadata operate to InstanceController.

* format code 50%

* complete bacth operation of metadata

* remove unnecessary test unit

* modify the variable name

* perfect log info

* modify consumer's dto to match it's description

* 1.rename class OperationContext -> InstanceOperationContext
2.move Map operation from NamingUtils to MapUtils

* check datum is null

* code refactor.

* 1. code refactor
2. modify the batch operate http param. just support (1 services : n instance)

* 1.set default clusterName if instance not set
2.fix client params not set instances bug

* npe fix

* 1.remove consistencyType *, just support ephemeral or persist.
2.remove moditfy property method in InstanceOperationContext and InstanceOperationInfo, it just defined by constructor.

* add instance controller test

* fix code too length

* update the param name

* add feature's version of start
WesleyOne pushed a commit to WesleyOne/nacos that referenced this issue Oct 20, 2020
…libaba#3912)

* feature. add update and delete operation on instance's metadata 90%

* 1.add unit test
2.fix-locateInstance error

* format code style

* add @link on class

* move metadata operate to InstanceController.

* format code 50%

* complete bacth operation of metadata

* remove unnecessary test unit

* modify the variable name

* perfect log info

* modify consumer's dto to match it's description

* 1.rename class OperationContext -> InstanceOperationContext
2.move Map operation from NamingUtils to MapUtils

* check datum is null

* code refactor.

* 1. code refactor
2. modify the batch operate http param. just support (1 services : n instance)

* 1.set default clusterName if instance not set
2.fix client params not set instances bug

* npe fix

* 1.remove consistencyType *, just support ephemeral or persist.
2.remove moditfy property method in InstanceOperationContext and InstanceOperationInfo, it just defined by constructor.

* add instance controller test

* fix code too length

* update the param name

* add feature's version of start
loveincode added a commit to Framework-Source-Code/nacos that referenced this issue Oct 21, 2020
* 'develop' of github.com:alibaba/nacos: (678 commits)
  Fix integration test error
  Fix unit test error in ci
  For checkStyle
  Modify the startup script custom configuration first default configuration (alibaba#4021)
  Revert "Naming module Raft protocol migration"
  [ISSUE alibaba#3904] feature - operate instance's metadata alonely (alibaba#3912)
  For alibaba#3710#, Fix special characters cannot be used in Metadata (alibaba#4019)
  [ISSUE-alibaba#3855] Provided a feature to view version comparisons in the configDetails page (alibaba#3988)
  Refactor dispatch task execute (alibaba#3995)
  Revert "for alibaba#3621 (alibaba#3668)" (alibaba#3999)
  Naming module Raft protocol migration (alibaba#3989)
  refactor: code refactor
  [ISSUE alibaba#3576] [Enhancement] Adding the destroy lifecycle method on NamingMaintainService (alibaba#3985)
  Fix issue 2866 (alibaba#3984)
  For alibaba#3384, Fix member extend info do not update error. (alibaba#3982)
  Fix#3973 (alibaba#3974)
  Move remove listener logic to ServiceManager
  Move remove listener logic to ServiceManager
  1.fix unit test can't pass (alibaba#3956)
  [ISSUE alibaba#3909] add domain's judgement (alibaba#3913)
  ...
@KomachiSion KomachiSion added this to the 1.4.0 milestone Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome kind/discussion Category issues related to discussion kind/feature type/feature
Projects
None yet
Development

No branches or pull requests

3 participants