Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service List Page Increase the number of pages switching function is the same as the configuration management page #3500

Closed
lidaoyang opened this issue Aug 3, 2020 · 2 comments · Fixed by #3511
Closed

Service List Page Increase the number of pages switching function is the same as the configuration management page #3500

lidaoyang opened this issue Aug 3, 2020 · 2 comments · Fixed by #3511
Labels
area/Nacos console Related to Nacos consle contribution welcome kind/enhancement Category issues or prs related to enhancement. kind/feature type/feature
Milestone
1.4.0

Comments

@lidaoyang
Copy link
Contributor

lidaoyang commented Aug 3, 2020 •
edited
Loading

The service list page defaults to 10 items per page. When the number of services exceeds 100, it is not conducive to service queries,The service list API supports page switching. You only need to implement this function on the page.

服务列表页默认每页是10条，当服务数超过100个后不利于服务的查询，看了服务列表API是支持页数切换的，只需要页面实现该功能就好了
@KomachiSion KomachiSion added kind/feature type/feature kind/enhancement Category issues or prs related to enhancement. area/Nacos console Related to Nacos consle contribution welcome labels Aug 3, 2020
@ljhrot
Copy link
Contributor

ljhrot commented Aug 3, 2020

@KomachiSion duplicate with #3439?

@lidaoyang
Copy link
Contributor Author

@ljhrot What I mean is that the service list also has the same functions as the configuration list. We recommend that you have a larger number of pages.
我说的是服务列表里面里也和配置列表一样的功能，建议页数大一点。

@ZZQ001010 ZZQ001010 mentioned this issue Aug 4, 2020
Merged
KomachiSion pushed a commit that referenced this issue Aug 4, 2020
@ZZQ001010
[ISSUE #3439] Increment console config page size (#3507)
e4fdc38 
* 配置pageSize列表 #3439

* Service List Page Increase the number of pages switching function is the same as the configuration management page #3500
@KomachiSion KomachiSion linked a pull request Aug 5, 2020 that will close this issue
[ISSUE #3500] Make page list of service manager same as config manager #3511
Merged
@KomachiSion KomachiSion added this to the 1.4.0 milestone Aug 5, 2020
KomachiSion pushed a commit that referenced this issue Aug 5, 2020
@ZZQ001010
[ISSUE #3500] Make page list of service manager same as config manager (
816113a 
#3511)

* 配置pageSize列表 #3439

* Service List Page Increase the number of pages switching function is the same as the configuration management page #3500

* issues#3500 编译之后的代码
KomachiSion pushed a commit that referenced this issue Aug 6, 2020
@ZZQ001010
When binding roles, the user list is changed to the drop-down selecti…
7a471c5 
…on mode （在绑定角色的时候用户列表改成下拉选中的模式) #3518 (#3522)

* 配置pageSize列表 #3439

* Service List Page Increase the number of pages switching function is the same as the configuration management page #3500

* issues#3500 编译之后的代码

* 在绑定角色的时候用户列表改成下拉选中的模式 #3518

* change code style

* delete unused import

* delete changed indent please.

* Javadoc add an ending period

* fix bad sql and change return type

* change js get value

* delete whitespace

* check code style

* add permissions, associated role, change to fuzzy matching drop-down(java code)

* add permissions, associated role, change to fuzzy matching drop-down(js code)

* delete "/"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/Nacos console Related to Nacos consle contribution welcome kind/enhancement Category issues or prs related to enhancement. kind/feature type/feature
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

[ISSUE #3500] Make page list of service manager same as config manager
3 participants
@ljhrot @lidaoyang @KomachiSion