Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbeddedStoragePersistServiceImpl and ExternalStoragePaginationHelperImpl use “+=” to concatenated String, will cause performance issue #3056

Closed
showkawa opened this issue Jun 12, 2020 · 2 comments

Comments

@showkawa
Copy link
Contributor

Issue Description

bug report - performance issue

Describe what happened (or what feature you want)

com.alibaba.nacos.config.server.service.repository.EmbeddedStoragePersistServiceImpl
and
com.alibaba.nacos.config.server.service.repository.ExternalStoragePaginationHelperImpl
use “+=” to concatenated String, will cause performance issue

Describe what you expected to happen

use StringBuilder will be better, and i will handle it

How to reproduce it (as minimally and precisely as possible)

  1. replace "+=" to StringBuilder append method

Tell us your environment

Anything else we need to know?

@showkawa
Copy link
Contributor Author

@i will solve it@

@chuntaojun
Copy link
Collaborator

Simplify the label of issue

@showkawa showkawa changed the title com.alibaba.nacos.config.server.service.repository.EmbeddedStoragePersistServiceImpl and com.alibaba.nacos.config.server.service.repository.ExternalStoragePaginationHelperImpl use “+=” to concatenated String, will cause performance issue EmbeddedStoragePersistServiceImpl and ExternalStoragePaginationHelperImpl use “+=” to concatenated String, will cause performance issue Jun 12, 2020
chuntaojun added a commit that referenced this issue Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants