Query information about clients that subscribe to the specified service - The returned value does not meet expectations

[Myheartwilgn]

Version：2.2.3~2.3.2
BugApi：Nacos Open API Doc -> /nacos/v2/ns/client/service/subscriber/list
Description：Null is returned when ip or port is null
Code：

  @GetMapping("/service/subscriber/list")
  @Secured(action = ActionTypes.READ, resource = "nacos/admin")
  public Result<List<ObjectNode>> getSubscribeClientList(
          @RequestParam(value = "namespaceId", required = false, defaultValue = Constants.DEFAULT_NAMESPACE_ID) String namespaceId,
          @RequestParam(value = "groupName", required = false, defaultValue = Constants.DEFAULT_GROUP) String groupName,
          @RequestParam(value = "ephemeral", required = false, defaultValue = "true") Boolean ephemeral,
          @RequestParam("serviceName") String serviceName, @RequestParam(value = "ip", required = false) String ip,
          @RequestParam(value = "port", required = false) Integer port) {
      Service service = Service.newService(namespaceId, groupName, serviceName, ephemeral);
      Collection<String> allClientsSubscribeService = clientServiceIndexesManager
              .getAllClientsSubscribeService(service);
      ArrayList<ObjectNode> res = new ArrayList<>();
      for (String clientId : allClientsSubscribeService) {
          Client client = clientManager.getClient(clientId);
          Subscriber subscriber = client.getSubscriber(service);
          if (!Objects.equals(subscriber.getIp(), ip) || !Objects.equals(port, subscriber.getPort())) {
              continue;
          }
          ObjectNode item = JacksonUtils.createEmptyJsonNode();
          item.put("clientId", clientId);
          item.put("ip", subscriber.getIp());
          item.put("port", subscriber.getPort());
          res.add(item);
      }
      return Result.success(res);
  }

BugCode：

    if (!Objects.equals(subscriber.getIp(), ip) || !Objects.equals(port, subscriber.getPort())) {
        continue;
    }

[KomachiSion]

What's your expected?

[Myheartwilgn]

What's your expected?
when ip or port is null, don't continue.
Now that the subscriber information is actually found, it is filtered out by "equal" when the ip or port is null, resulting in an empty subscriber list returned.

[KomachiSion]

So you want when ip or port not input, return all subscribers of this service?

[Myheartwilgn]

So you want when ip or port not input, return all subscribers of this service?

Yes, in fact, according to the interface documentation, it should be

[KomachiSion]

Maybe add a new param to support when ip or port is null, return all infos. default same with old version.

Or in Nacos 3.0, default change to return all infos when ip or port is null.

[Myheartwilgn]

Maybe add a new param to support when ip or port is null, return all infos. default same with old version.

Or in Nacos 3.0, default change to return all infos when ip or port is null.

Good！Thanks！

[zhouchunhai]

@i will solve it@

[zhouchunhai]

I think there is no need to add a new param.