[ISSUE#11494] Fix frequently request login api when using 2.X client …

…with username. (#11495) * Fix frequently request login api when using 2.X client with username. * Fix frequently request login api when using 2.X client with username.
alibaba · Dec 12, 2023 · a3420b7 · a3420b7
1 parent 26d045c
commit a3420b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...h-plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/token/impl/JwtTokenManager.java b/...h-plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/token/impl/JwtTokenManager.java
@@ -49,8 +49,7 @@
 @Component
 public class JwtTokenManager extends Subscriber<ServerConfigChangeEvent> implements TokenManager {
 
-    @Deprecated
-    private static final String AUTHORITIES_KEY = "auth";
+    private static final String AUTH_DISABLED_TOKEN = "AUTH_DISABLED";
 
     /**
      * Token validity time(seconds).
@@ -105,7 +104,7 @@ public String createToken(Authentication authentication) {
      */
     public String createToken(String userName) {
         if (!authConfigs.isAuthEnabled()) {
-            return StringUtils.EMPTY;
+            return AUTH_DISABLED_TOKEN;
         }
         checkJwtParser();
         return jwtParser.jwtBuilder().setUserName(userName).setExpiredTime(this.tokenValidityInSeconds).compact();

diff --git a/...ugin/src/test/java/com/alibaba/nacos/plugin/auth/impl/token/impl/JwtTokenManagerTest.java b/...ugin/src/test/java/com/alibaba/nacos/plugin/auth/impl/token/impl/JwtTokenManagerTest.java
@@ -110,7 +110,7 @@ public void testGetExpiredTimeInSeconds() throws AccessException {
     public void testCreateTokenWhenDisableAuth() {
         when(authConfigs.isAuthEnabled()).thenReturn(false);
         jwtTokenManager = new JwtTokenManager(authConfigs);
-        assertEquals("", jwtTokenManager.createToken("nacos"));
+        assertEquals("AUTH_DISABLED", jwtTokenManager.createToken("nacos"));
     }
 
     @Test