[ISSUE #8925] fix that the replaceAll operation is invalid (#8929)

Close #8925
alibaba · Aug 12, 2022 · 8f8a1f3 · 8f8a1f3
1 parent 21b624e
commit 8f8a1f3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/client/src/main/java/com/alibaba/nacos/client/config/impl/ServerListManager.java b/client/src/main/java/com/alibaba/nacos/client/config/impl/ServerListManager.java
@@ -223,24 +223,24 @@ public ServerListManager(Properties properties) throws NacosException {
     }
 
     private String initServerName(Properties properties) {
-        String serverName = "";
+        String serverName;
         //1.user define server name.
         if (properties != null && properties.containsKey(PropertyKeyConst.SERVER_NAME)) {
             serverName = properties.get(PropertyKeyConst.SERVER_NAME).toString();
         } else {
             // if fix url,use fix url join string.
             if (isFixed) {
                 serverName = FIXED_NAME + "-" + (StringUtils.isNotBlank(namespace) ? (StringUtils.trim(namespace) + "-")
-                        : "") + getFixedNameSuffix(serverUrls.toArray(new String[serverUrls.size()]));
+                        : "") + getFixedNameSuffix(serverUrls.toArray(new String[0]));
             } else {
                 //if use endpoint ,  use endpoint ,content path ,serverlist name
                 serverName = CUSTOM_NAME + "-" + String
                         .join("_", endpoint, String.valueOf(endpointPort), contentPath, serverListName) + (
                         StringUtils.isNotBlank(namespace) ? ("_" + StringUtils.trim(namespace)) : "");
             }
         }
-        serverName.replaceAll("\\/", "_");
-        serverName.replaceAll("\\:", "_");
+        serverName = serverName.replaceAll("\\/", "_");
+        serverName = serverName.replaceAll("\\:", "_");
 
         return serverName;
     }