[ISSUE #11255]Update PathEncoderManagerTest#testEncodeWithNonExistOs. (…

…#11256) * [ISSUE #11255]Remove PathEncoderManagerTest#testEncodeWithNonExistOs. * [ISSUE #11255]Update PathEncoderManagerTest#testEncodeWithNonExistOs.
alibaba · Oct 17, 2023 · 1df0234 · 1df0234
1 parent c4aac2b
commit 1df0234
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/common/src/test/java/com/alibaba/nacos/common/pathencoder/PathEncoderManagerTest.java b/common/src/test/java/com/alibaba/nacos/common/pathencoder/PathEncoderManagerTest.java
@@ -70,24 +70,25 @@ public void testInitWithWindows()
     public void testWindowsEncode() throws Exception {
         // load static
         PathEncoderManager instance = PathEncoderManager.getInstance();
-        // remove impl
-        targetEncoder.set(instance, null);
-        // try to encode, non windows
         String case1 = "aa||a";
-        Assert.assertEquals(PathEncoderManager.getInstance().encode(case1), case1);
         String case2 = "aa%A9%%A9%a";
-        Assert.assertEquals(PathEncoderManager.getInstance().decode(case2), case2);
         // try to encode if in windows
         targetEncoder.set(instance, new WindowsEncoder());
         Assert.assertEquals(PathEncoderManager.getInstance().encode(case1), case2);
         Assert.assertEquals(PathEncoderManager.getInstance().decode(case2), case1);
     }
 
     @Test
-    public void testEncodeWithNonExistOs() {
-        System.setProperty("os.name", "non-exist");
-        String testCase = "aa||a";
-        Assert.assertEquals(testCase, PathEncoderManager.getInstance().encode(testCase));
+    public void testEncodeWithNonExistOs() throws Exception {
+        // load static
+        PathEncoderManager instance = PathEncoderManager.getInstance();
+        // remove impl
+        targetEncoder.set(instance, null);
+        // try to encode, non windows
+        String case1 = "aa||a";
+        Assert.assertEquals(PathEncoderManager.getInstance().encode(case1), case1);
+        String case2 = "aa%A9%%A9%a";
+        Assert.assertEquals(PathEncoderManager.getInstance().decode(case2), case2);
     }
 
     @Test