Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #80] dubbo录制问题 #111

Closed
wants to merge 1 commit into from
Closed

[ISSUE #80] dubbo录制问题 #111

wants to merge 1 commit into from

Conversation

MI-cool
Copy link
Contributor

@MI-cool MI-cool commented Jun 17, 2021

先说结论,dubbo流量录制拿不到subInvocations的问题是因为同时注册了invoke和onResponse两个方法,导致一次调用过程开启了两次trace。

相比于PR #79 本PR调整很小,核心逻辑是调整了默认的isEntranceBegin、isEntranceFinish。

@zhaoyb1990
Copy link
Contributor

invoke和onResponse两次调用会有线程切换吗? 如果没有的话,及时开启两次也不会有问题

@MI-cool
Copy link
Contributor Author

MI-cool commented Jun 17, 2021

问题在以下方法的调用将invoke时创建的trace context清除了,然后onResponse开启的新trace拿不到subInvocations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants