feat: useMouse #147
Merged
feat: useMouse #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/umijs/hooks/5soscs0d4 |
awmleer
reviewed
Nov 13, 2019
awmleer
reviewed
Nov 13, 2019
brickspert
reviewed
Nov 13, 2019
brickspert
reviewed
Nov 17, 2019
src/useMouse/index_cn.mdx
Outdated
|
|
||
| # useMouse | ||
|
|
||
| 一个跟踪鼠标位置的 hook |
src/useSize/index.ts
Outdated
| @@ -3,15 +3,15 @@ import ResizeObserver from 'resize-observer-polyfill'; | |||
|
|
|||
| type Arg = HTMLElement | (() => HTMLElement) | null; | |||
|
|
|||
| type Size = { width: number; height: number }; | |||
| type Size = { width: number; height: number; top: number; left: number }; | |||
There was a problem hiding this comment.
我还是认为 useSize 加上 top 和 left 不太合适。 @awmleer
There was a problem hiding this comment.
我觉得加上也不是不可以，毕竟有的时候还是会用到 top 和 left 的。。（虽然语义上有点奇怪）
brickspert
approved these changes
Nov 17, 2019
|
export from src/index.ts ? |
|
也许可以做一层性能上的优化，就是像 不过可能也不是很要紧。。 |
good idea，不过这个以后再做吧~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.