Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support only watching key resources in one namespace #1821

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Feb 26, 2025

Ⅰ. Describe what this PR did

Support only watching key resources in one namespace. User can use --watchNamespace parameter to restrict watching logics to a certain namespace.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO marked this pull request as draft February 26, 2025 13:41
@CH3CHO CH3CHO marked this pull request as ready for review February 26, 2025 14:32
@CH3CHO CH3CHO force-pushed the feat/one-namespace branch from e6bbe09 to d822ca6 Compare February 26, 2025 14:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 64.40678% with 21 lines in your changes missing coverage. Please review.

Project coverage is 43.39%. Comparing base (ef31e09) to head (d26ae4e).
Report is 323 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/kube/http2rpc/controller.go 55.55% 3 Missing and 1 partial ⚠️
pkg/ingress/kube/kingress/controller.go 63.63% 3 Missing and 1 partial ⚠️
pkg/ingress/kube/mcpbridge/controller.go 55.55% 3 Missing and 1 partial ⚠️
pkg/ingress/kube/wasmplugin/controller.go 55.55% 3 Missing and 1 partial ⚠️
pkg/ingress/translation/translation.go 60.00% 1 Missing and 1 partial ⚠️
pkg/ingress/config/ingress_config.go 83.33% 1 Missing ⚠️
pkg/ingress/config/kingress_config.go 66.66% 1 Missing ⚠️
pkg/ingress/kube/ingressv1/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1821      +/-   ##
==========================================
+ Coverage   35.91%   43.39%   +7.48%     
==========================================
  Files          69       76       +7     
  Lines       11576    12301     +725     
==========================================
+ Hits         4157     5338    +1181     
+ Misses       7104     6629     -475     
- Partials      315      334      +19     
Files with missing lines Coverage Δ
pkg/bootstrap/server.go 58.20% <100.00%> (-0.19%) ⬇️
pkg/ingress/kube/ingress/controller.go 59.66% <100.00%> (-0.70%) ⬇️
pkg/ingress/kube/secret/controller.go 100.00% <100.00%> (ø)
pkg/ingress/config/ingress_config.go 12.99% <83.33%> (-0.89%) ⬇️
pkg/ingress/config/kingress_config.go 16.92% <66.66%> (-0.05%) ⬇️
pkg/ingress/kube/ingressv1/controller.go 5.28% <0.00%> (+0.06%) ⬆️
pkg/ingress/translation/translation.go 23.33% <60.00%> (ø)
pkg/ingress/kube/http2rpc/controller.go 45.45% <55.55%> (ø)
pkg/ingress/kube/kingress/controller.go 44.36% <63.63%> (+1.66%) ⬆️
pkg/ingress/kube/mcpbridge/controller.go 45.45% <55.55%> (ø)
... and 1 more

... and 60 files with indirect coverage changes

@CH3CHO CH3CHO marked this pull request as draft February 27, 2025 10:56
@CH3CHO CH3CHO force-pushed the feat/one-namespace branch from d822ca6 to 2388730 Compare February 27, 2025 11:02
@CH3CHO CH3CHO marked this pull request as ready for review February 27, 2025 14:58
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 188914a into alibaba:main Mar 3, 2025
14 checks passed
@CH3CHO CH3CHO deleted the feat/one-namespace branch March 3, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants