Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): fix field doesnt update correctly in designable mode #1799

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

MisicDemone
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

  1. fix field doesnt update correctly in designable mode
  2. fix doc error

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #1799 (4988242) into formily_next (2369c00) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #1799      +/-   ##
================================================
+ Coverage         92.54%   92.56%   +0.01%     
================================================
  Files               135      135              
  Lines              6013     6029      +16     
  Branches           1495     1494       -1     
================================================
+ Hits               5565     5581      +16     
  Misses              444      444              
  Partials              4        4              
Impacted Files Coverage Δ
packages/vue/src/components/ArrayField.ts 96.96% <100.00%> (+0.54%) ⬆️
packages/vue/src/components/Field.ts 100.00% <100.00%> (ø)
packages/vue/src/components/FormProvider.ts 100.00% <100.00%> (ø)
packages/vue/src/components/ObjectField.ts 96.96% <100.00%> (+0.54%) ⬆️
packages/vue/src/components/VoidField.ts 100.00% <100.00%> (ø)
packages/vue/src/hooks/useAttach.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2369c00...4988242. Read the comment docs.

@janryWang janryWang merged commit 837cfc0 into alibaba:formily_next Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants