chore: remove tslint and use typescript-eslint #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: remove tslint and eslint to lint typescript chore: better eslint setting
monkindey
reviewed
Jul 10, 2019
package.json
Outdated
| "lint": "eslint \"packages/!(docs)/**/*.js\" \"scripts/**/*.js\"", | ||
| "tslint": "npm run tslint:once && onchange 'packages/**/*.ts' -- npm run tslint:once", | ||
| "tslint:once": "tslint --fix --project ./ ", | ||
| "lint": "eslint --ext .js,.ts,.tsx \"packages/!(docs)/**/*.@(ts|tsx|js)\" \"scripts/**/*.@(ts|tsx|js)\"", |
There was a problem hiding this comment.
要不要结合 lint-staged 只检测修改的文件哦？感觉每次执行 lint 有点慢
scripts/.eslintrc
Outdated
| "ecmaFeatures": { | ||
| "jsx": true | ||
| } | ||
| }, |
There was a problem hiding this comment.
这个文件的作用是？还有我的 vscode 显示这个文件 ESLint 有错误
There was a problem hiding this comment.
多了一个逗号，这个.eslintrc是单独配置这个目录下的eslint规则。因为下面都是一些编译的脚本规则应该是不一样的，比如说允许使用require，env应该是node等
.eslintrc
Outdated
| // allow specifying true explicitly for boolean props | ||
| "react/jsx-boolean-value": 0, | ||
| "react-hooks/rules-of-hooks": "error", | ||
| "react/no-did-update-set-state": 0, | ||
| "jsx-quotes":"off" | ||
| // maybe we should no-public | ||
| "@typescript-eslint/explicit-member-accessibility": "off", |
.eslintrc
Outdated
| // maybe we should no-public | ||
| "@typescript-eslint/explicit-member-accessibility": "off", | ||
| "@typescript-eslint/indent": ["error", 2], | ||
| "@typescript-eslint/interface-name-prefix": 0, |
There was a problem hiding this comment.
这条规则的意思是接口不能以I开头,不关掉就各种错误了
.eslintrc
Outdated
| "@typescript-eslint/explicit-function-return-type": 0, | ||
| "@typescript-eslint/no-parameter-properties": 0, | ||
| "@typescript-eslint/no-use-before-define": 0, | ||
| // "@typescript-eslint/no-var-requires": 1, |
.eslintrc
Outdated
| "@typescript-eslint/no-explicit-any": 0, | ||
| "@typescript-eslint/explicit-function-return-type": 0, | ||
| "@typescript-eslint/no-parameter-properties": 0, | ||
| "@typescript-eslint/no-use-before-define": 0, |
There was a problem hiding this comment.
js文件里面违反这条规则的代码有点多。要不先不管js文件吧。。。
.eslintrc
Outdated
| "@typescript-eslint/no-parameter-properties": 0, | ||
| "@typescript-eslint/no-use-before-define": 0, | ||
| // "@typescript-eslint/no-var-requires": 1, | ||
| "@typescript-eslint/array-type":0, |
.eslintrc
Outdated
| "@typescript-eslint/no-use-before-define": 0, | ||
| // "@typescript-eslint/no-var-requires": 1, | ||
| "@typescript-eslint/array-type":0, | ||
| "@typescript-eslint/class-name-casing": 0, |
There was a problem hiding this comment.
因为代码里面很多违反这条规则的情况，比如：fileSetting，defaultValueCascader之类的。不过都是js文件。要不我们先不管这些 js文件，因为反正都会用ts重构掉
monkindey
reviewed
Jul 10, 2019
| @@ -65,8 +65,12 @@ export class Row extends Component<IRowProps> { | |||
| ...(others.style || {}) | |||
| } | |||
| newChildren = Children.map(children, (child: React.ReactElement) => { | |||
| // @ts-ignore | |||
| if (child && child.type && typeof child.type === 'function' && child.type.isNextCol) { | |||
There was a problem hiding this comment.
这个改动好像会报 typescript 错误吧？因为这个 isNextCol 太随意了，但是又不能去掉
|
@janryWang 以后我自己来merge吧，感觉每个pr提交次数太多，squash一下会比较好 |
|
他就是用 squash 的吧 |
|
@monkindey 好吧，merge squash也行 |
ZirkleTsing
pushed a commit
that referenced
this pull request
May 14, 2020
* chore: remove tslint and use typescript-eslint feat: remove tslint and eslint to lint typescript chore: better eslint setting * chore: integrate prettier into eslint * chore: downgrade lint-staged version * fix: child.type.isNextCol error * chore: better eslint config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用typescript-eslint来代替tslint
PS： 很多还没用ts重构的项目文件被eslint给autofix了，不过应该不影响。