Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue1866. #1880

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix issue1866. #1880

merged 3 commits into from
Sep 26, 2023

Conversation

a1batr0ss
Copy link
Contributor

What this PR does / why we need it?

修复Issue1866中WriteNullNumberAsZero不生效的问题

Summary of your change

在生成字节码时(ObjectWriterCreatorASM.gwInt32()),没有对Field.features进行判断(@JSONField(serializeFeatures = JSONWriter.Feature.WriteNullNumberAsZero存放在Field.features中),只判断了JSONWriter.context.features.

ps:
1、JSONWriter.context.features和Field.features之间关联吗?
2、ObjectWriterCreatorASM的其他函数, JSONWRITER的函数似乎都只判断了JSONWriter.context.features,是我理解有问题吗?

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2023

CLA assistant check
All committers have signed the CLA.

@wenshao
Copy link
Member

wenshao commented Sep 19, 2023

单测跑不过

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (8953c18) 73.24% compared to head (4ae7001) 73.22%.
Report is 42 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1880      +/-   ##
============================================
- Coverage     73.24%   73.22%   -0.02%     
- Complexity    21504    21532      +28     
============================================
  Files           646      646              
  Lines         87376    87426      +50     
  Branches      19065    19078      +13     
============================================
+ Hits          64001    64022      +21     
- Misses        15459    15493      +34     
+ Partials       7916     7911       -5     
Files Coverage Δ
...ibaba/fastjson2/writer/ObjectWriterCreatorASM.java 92.72% <33.33%> (-0.41%) ⬇️

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenshao
Copy link
Member

wenshao commented Sep 23, 2023

请签署SLA

@wenshao wenshao merged commit a6a7d82 into alibaba:main Sep 26, 2023
@wenshao wenshao added this to the 2.0.41 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants