Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parsing exception for issue#1724 #1725

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

kraity
Copy link
Collaborator

@kraity kraity commented Aug 8, 2023

What this PR does / why we need it?

Parsing exception for issue #1724

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

kraity added 2 commits August 8, 2023 13:24
Signed-off-by: Kraity <kraty@krait.cn>
Signed-off-by: Kraity <kraty@krait.cn>
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Patch coverage: 55.43% and project coverage change: -0.05% ⚠️

Comparison is base (6a09ae6) 75.27% compared to head (663f035) 75.22%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1725      +/-   ##
============================================
- Coverage     75.27%   75.22%   -0.05%     
  Complexity    21240    21240              
============================================
  Files           632      632              
  Lines         84570    84568       -2     
  Branches      18667    18679      +12     
============================================
- Hits          63658    63617      -41     
- Misses        13034    13065      +31     
- Partials       7878     7886       +8     
Files Changed Coverage Δ
...ain/java/com/alibaba/fastjson2/JSONReaderUTF8.java 69.91% <38.46%> (-0.31%) ⬇️
...in/java/com/alibaba/fastjson2/JSONReaderASCII.java 86.73% <77.50%> (-0.87%) ⬇️
...in/java/com/alibaba/fastjson2/JSONReaderUTF16.java 72.67% <77.50%> (-0.19%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kraity kraity requested a review from wenshao August 8, 2023 05:51
@wenshao wenshao merged commit af9a75c into alibaba:main Aug 9, 2023
@kraity kraity deleted the issue1724 branch August 10, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants