Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue1603 #1604

Merged
merged 4 commits into from
Jun 28, 2023
Merged

fix issue1603 #1604

merged 4 commits into from
Jun 28, 2023

Conversation

GabrielHwang
Copy link
Contributor

@GabrielHwang GabrielHwang commented Jun 27, 2023

What this PR does / why we need it?

修改 #1603 中最后位置是null时,多一个逗号的问题
BUG定位到这里:

for (Map.Entry<String, Object> entry : map.entrySet()) {
if (!first) {
if (off == bytes.length) {
ensureCapacity(off + 1);
}
bytes[off++] = ',';
}

Summary of your change

增加了一个是否加入逗号的判断

@wenshao
Copy link
Member

wenshao commented Jun 27, 2023

请在本地执行mvn validate修复checkstyle的问题

@wenshao wenshao added this to the 2.0.35 milestone Jun 27, 2023
@yanxutao89
Copy link
Collaborator

请参考其他测试用例调整。1.测试用例类名;2.采用assert验证结果。

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (af0f79b) 74.70% compared to head (328e293) 74.69%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1604      +/-   ##
============================================
- Coverage     74.70%   74.69%   -0.02%     
  Complexity    20734    20734              
============================================
  Files           642      642              
  Lines         83128    83129       +1     
  Branches      18026    18027       +1     
============================================
- Hits          62100    62090      -10     
- Misses        13742    13751       +9     
- Partials       7286     7288       +2     
Impacted Files Coverage Δ
...ain/java/com/alibaba/fastjson2/JSONWriterUTF8.java 78.03% <100.00%> (+0.07%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GabrielHwang
Copy link
Contributor Author

请参考其他测试用例调整。1.测试用例类名;2.采用assert验证结果。
已修改,麻烦再帮忙看一下,感谢您的耐心指教 @yanxutao89

@wenshao wenshao merged commit f7344bb into alibaba:main Jun 28, 2023
3 checks passed
@wenshao
Copy link
Member

wenshao commented Jul 9, 2023

@GabrielHwang GabrielHwang deleted the fixIssue1603 branch September 5, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants