Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed enum mismatch #1581

Merged
merged 2 commits into from
Jun 17, 2023
Merged

Fixed enum mismatch #1581

merged 2 commits into from
Jun 17, 2023

Conversation

kraity
Copy link
Collaborator

@kraity kraity commented Jun 17, 2023

What this PR does / why we need it?

Fixed enum mismatch for issue #1578

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Signed-off-by: Kraity <kraty@krait.cn>
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2023

Codecov Report

Patch coverage: 64.28% and project coverage change: +0.22 🎉

Comparison is base (2534e1e) 75.78% compared to head (f257ea0) 76.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1581      +/-   ##
============================================
+ Coverage     75.78%   76.00%   +0.22%     
+ Complexity    20617    20546      -71     
============================================
  Files           632      620      -12     
  Lines         81398    80903     -495     
  Branches      17755    17676      -79     
============================================
- Hits          61686    61491     -195     
+ Misses        12456    12173     -283     
+ Partials       7256     7239      -17     
Impacted Files Coverage Δ
...baba/fastjson2/reader/ObjectReaderImplEnum2X4.java 61.45% <50.00%> (+0.82%) ⬆️
...alibaba/fastjson2/reader/ObjectReaderImplEnum.java 74.64% <68.18%> (-0.54%) ⬇️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kraity kraity requested a review from wenshao June 17, 2023 07:44
@wenshao
Copy link
Member

wenshao commented Jun 17, 2023

ObjectReaderImplEnum2X4 这个也要考虑

@kraity
Copy link
Collaborator Author

kraity commented Jun 17, 2023

ObjectReaderImplEnum2X4 这个也要考虑

收到

Signed-off-by: Kraity <kraty@krait.cn>
@wenshao wenshao merged commit ea3bc5d into alibaba:main Jun 17, 2023
@kraity kraity deleted the issue1578 branch June 17, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants