Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2492 处理了小数点后有填充字符读取为String，小数点未被处理的情况 #2493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #2492 处理了小数点后有填充字符读取为String，小数点未被处理的情况 #2493

wants to merge 2 commits into from

Conversation

edalring
Copy link

Fix #2492

处理了小数点后有填充字符读取为String，小数点未被处理的情况，增加了测试文件

@edalring edalring mentioned this pull request May 23, 2022
Open
@zhuangjiaju
Copy link
Collaborator

兄弟这块代码我也没看懂，也是poi拷贝过来的，建议直接PR提交到POI，我不敢合并。

@zhuangjiaju zhuangjiaju added the question Further information is requested label Feb 10, 2023
@zhuangjiaju
Copy link
Collaborator

非常感谢您的PR，问题比较多：

  1. if else 太多 ，没看懂需求， 这种要考虑switch
  2. 然后没看懂实际解决的问题， 和bug不一致

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edalring @zhuangjiaju