Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "解决Druid多classloader Mbean注册卸载过程中的问题 " #3167

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Revert "解决Druid多classloader Mbean注册卸载过程中的问题 " #3167

merged 1 commit into from
Apr 7, 2019

Conversation

wenshao
Copy link
Member

@wenshao wenshao commented Apr 7, 2019

Reverts #3164

@wenshao wenshao merged commit 4a79e70 into master Apr 7, 2019
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Geker
Copy link
Contributor

Geker commented Apr 21, 2019

why revert #3164 merge

@wenshao
Copy link
Member Author

wenshao commented Apr 21, 2019

动态的MBeanName相关的工具类无法获得MBean，回归测试也跑不过

@Geker
Copy link
Contributor

Geker commented Apr 22, 2019

是的，对应的测试类应该也需要做对应的修改，我再优化下单元测试吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenshao @CLAassistant @Geker