Skip to content

fix(NFC): bazel build#452

Open
c8ef wants to merge 1 commit intoalibaba:mainfrom
c8ef:bazel
Open

fix(NFC): bazel build#452
c8ef wants to merge 1 commit intoalibaba:mainfrom
c8ef:bazel

Conversation

@c8ef
Copy link

@c8ef c8ef commented Feb 25, 2026

Why

Current bazel build not work out of the box.

What is changing

  1. in bazel 9, function like cc_test is not builtin, need to import from rules_cc.
  2. the version bump in module.bazel is needed, some old version use old function parameter that does not exist in bazel 9.
  3. the bazel format change is generated by buildifier.
  4. the cpp file change is due to -Werror=sign-compare

@c8ef
Copy link
Author

c8ef commented Feb 25, 2026

PTAL @ChuanqiXu9 @poor-circle

Copy link
Collaborator

@ChuanqiXu9 ChuanqiXu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge after CI gets green

@c8ef
Copy link
Author

c8ef commented Feb 26, 2026

LGTM.

Thanks for the review!

Will merge after CI gets green

I believe the related CI is now passing for macos bazel build and test, as well as linux bazel build (except for one test failure that I cannot reproduce on my own x86 machine). While some CI are already failing in the main branch, I am willing to investigate and address them in subsequent patches for better clarity and coherence.

@c8ef c8ef changed the title fix: bazel build fix(NFC): bazel build Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants