Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API gateway adapter common module and Spring Cloud Gateway adapter #695

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Apr 22, 2019

Describe what this PR does / why we need it

Add an API gateway adapter common module, as well as Sentinel Spring Cloud Gateway adapter module and implementation.

Does this pull request fix one issue?

Resolves #86

Describe how you did it

  • Add sentinel-api-gateway-adapter-common module for universal gateway rule and API definition management
  • Add Sentinel Spring Cloud Gateway adapter module and implementation (based on sentinel-api-gateway-adapter-common and sentinel-reactor-adapter)

Describe how to verify it

Run the test cases and demo.

Special notes for reviews

NONE

@sczyh30 sczyh30 added to-review To review kind/feature Category issues or prs related to feature request. labels Apr 22, 2019
@sczyh30 sczyh30 added this to the 1.6.0 milestone Apr 22, 2019
@sczyh30 sczyh30 self-assigned this Apr 22, 2019
@sczyh30 sczyh30 added the size/XXL Indicate a PR that changes 1000+ lines. label Apr 22, 2019
@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #695 into master will decrease coverage by 0.1%.
The diff coverage is 39.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #695      +/-   ##
============================================
- Coverage     41.38%   41.28%   -0.11%     
- Complexity     1236     1319      +83     
============================================
  Files           266      288      +22     
  Lines          7969     8478     +509     
  Branches       1091     1147      +56     
============================================
+ Hits           3298     3500     +202     
- Misses         4258     4545     +287     
- Partials        413      433      +20
Impacted Files Coverage Δ Complexity Δ
...pter/gateway/common/api/ApiPredicateGroupItem.java 0% <0%> (ø) 0 <0> (?)
...er/gateway/sc/callback/GatewayCallbackManager.java 0% <0%> (ø) 0 <0> (?)
...gateway/common/api/matcher/AbstractApiMatcher.java 0% <0%> (ø) 0 <0> (?)
...dapter/gateway/sc/route/RegexRoutePathMatcher.java 0% <0%> (ø) 0 <0> (?)
...xception/SentinelGatewayBlockExceptionHandler.java 0% <0%> (ø) 0 <0> (?)
...teway/sc/callback/RedirectBlockRequestHandler.java 0% <0%> (ø) 0 <0> (?)
...apter/gateway/common/param/GatewayParamParser.java 0% <0%> (ø) 0 <0> (?)
...ateway/sc/callback/DefaultBlockRequestHandler.java 0% <0%> (ø) 0 <0> (?)
...SpringCloudGatewayApiDefinitionChangeObserver.java 100% <100%> (ø) 2 <2> (?)
...pter/gateway/common/rule/GatewayRuleConverter.java 100% <100%> (ø) 2 <2> (?)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f713bd...a0deec5. Read the comment docs.

@sczyh30 sczyh30 force-pushed the feature/gateway-sc branch 2 times, most recently from 20d7aac to d578e0a Compare April 22, 2019 13:54
sczyh30 added 3 commits April 23, 2019 11:41
…rule and API definition management

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 force-pushed the feature/gateway-sc branch from aef56d3 to a0deec5 Compare April 23, 2019 03:41
Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or prs related to feature request. size/XXL Indicate a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Integration with Spring Cloud Gateway
3 participants