-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor flow algorithm for parameter flow control and support more traffic shaping mode #677
Conversation
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
============================================
+ Coverage 40.83% 41.65% +0.82%
- Complexity 1220 1249 +29
============================================
Files 267 266 -1
Lines 7920 7992 +72
Branches 1076 1103 +27
============================================
+ Hits 3234 3329 +95
+ Misses 4290 4247 -43
- Partials 396 416 +20
Continue to review full report at Codecov.
|
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe what this PR does / why we need it
Refactor flow algorithm for parameter flow control and support more traffic shaping mode.
Does this pull request fix one issue?
Resolves #640
Describe how you did it
ParamFlowRule
to support burst count, throttle, statistic interval per rule.HotParamLeapArray
and use token bucket algorithm directly.Some of the code should be rearranged and improved.
Describe how to verify it
Run the test cases and demo.
Special notes for reviews
This PR contains breaking changes. Please take it carefully.