-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTP POST request for update operations in SentinelApiClient of Sentinel dashboard #620
Conversation
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
============================================
- Coverage 41.1% 41.06% -0.04%
- Complexity 1216 1332 +116
============================================
Files 267 284 +17
Lines 7854 8925 +1071
Branches 1062 1193 +131
============================================
+ Hits 3228 3665 +437
- Misses 4233 4794 +561
- Partials 393 466 +73
Continue to review full report at Codecov.
|
Good job. I'll review these days :) |
I've reviewed the code about
So for |
Yes. |
...nel-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/client/SentinelApiClient.java
Show resolved
Hide resolved
And could you please split your commit into two parts, one about changes for the transport module, another for the dashboard. Commits about dashboard should be prefixed with |
Enhancement: SentinelVersion parsing logic Bug fix: comparation bug of SentinelVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing! |
[ISSUE alibaba#608] Polish filter example
Describe what this PR does / why we need it
Feature for transport module: Make transport-netty-http/transport-simple-http support posting (split to #667)
For dashboard:
Restructure
: refineSentinelApiClient
to support posting and make it simpleEnhancement
:SentinelVersion
parsing logicBug fix
: comparison bug of SentinelVersionDoes this pull request fix one issue?
Relevant issue #618
Describe how you did it
Make
netty-http
support bothform-encoded
/multipart
post requests.Make
simple-http
supportform-encoded
.Multipart
requests can also be support too if necessary.Form-encoded
would be the standard support for transport modules.Describe how to verify it
Submit big rules collection. For example, more than 30 entries which will overflow the URI limitation in RFC.