-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SimpleDateFormat concurrent issue in CspFormatter #548
Conversation
Hi, thanks for contributing. Could you please sign the CLA here? And please make sure the email of your commits match your GitHub email. 感谢贡献,请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配并 确认一下 CLA。另外请 reformat 相关代码,确保符合 Alibaba Java Code Guideline。 |
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
============================================
- Coverage 37.96% 37.91% -0.05%
+ Complexity 1111 1108 -3
============================================
Files 259 259
Lines 8177 8173 -4
Branches 1115 1113 -2
============================================
- Hits 3104 3099 -5
- Misses 4668 4670 +2
+ Partials 405 404 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
============================================
+ Coverage 37.51% 37.96% +0.45%
- Complexity 1102 1110 +8
============================================
Files 259 259
Lines 8171 8173 +2
Branches 1113 1113
============================================
+ Hits 3065 3103 +38
+ Misses 4715 4666 -49
- Partials 391 404 +13
Continue to review full report at Codecov.
|
修改SimpleDateFormat format方法线程不安全问题 reformat 代码,保持阿里编码规范
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing! |
Describe what this PR does / why we need it
解决了 #547 我提的issue 存在的问题
Does this pull request fix one issue?
Fixes #547
Describe how you did it
将SimpleDateFormat 包装为ThreadLocal方式来解决多线程安全问题
Describe how to verify it
Special notes for reviews