-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carry the triggered rule in subclasses of BlockException #469
Conversation
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that moving getRule ()
method into BlockException
is more appropriate.
…lasses Signed-off-by: Eric Zhao <sczyh16@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Due to the fact that JLS does not allow generic subclasses of |
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
===========================================
+ Coverage 37.65% 39.25% +1.6%
- Complexity 984 1077 +93
===========================================
Files 235 236 +1
Lines 7434 7713 +279
Branches 1018 1085 +67
===========================================
+ Hits 2799 3028 +229
- Misses 4274 4294 +20
- Partials 361 391 +30
Continue to review full report at Codecov.
|
Describe what this PR does / why we need it
Carry the triggered rule in subclasses of BlockException. See #424 for more information.
Does this pull request fix one issue?
Resolves #424
Describe how you did it
Refactor each subclass of
BlockException
and add arule
field to carry the triggered rule (except theSystemRule
). Users can get the trigger rule from thegetRule()
method.Describe how to verify it
It's a compatible change. The CI should pass.
Special notes for reviews
NONE