Refactor the underlying model of SystemRuleManager #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huang-gz
changed the title
sczyh30
added
to-review
LearningGp
requested changes
Dec 24, 2023
| assertEquals(1.2d, rules.get(0).getHighestSystemLoad(), 0.01); | ||
| assertEquals(1.2d, SystemRuleManager.getSystemLoadThreshold(), 0.01); | ||
| assertEquals(1.2d, rules.get(0).getTriggerCount(), 0.01); | ||
| assertEquals(1.2d, SystemRuleManager.getRules().get(0).getTriggerCount(), 0.01); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCheckMaxCpuUsageNotBBR() throws Exception { |
There was a problem hiding this comment.
Test failed, please fix it.
| public int getType() { | ||
| return type; | ||
| } | ||
| } |
There was a problem hiding this comment.
A formatting mistake here.
| public void setMaxThread(long maxThread) { | ||
| this.maxThread = maxThread; | ||
| } | ||
| private double triggerCount; |
There was a problem hiding this comment.
Just use count to name it like any other rule.
| */ | ||
| public class SystemRuleManagerTest { | ||
|
|
||
| @Test | ||
| public void testLoadInvalidRules() { | ||
| SystemRule rule1 = new SystemRule(); | ||
| rule1.setHighestSystemLoad(-0.9d); | ||
| rule1.setTriggerCount(-0.9d); |
There was a problem hiding this comment.
Try to avoid this naming scheme, loadRule, cpuUsageRule may be more fitting.
| @@ -87,19 +87,33 @@ public void run() { | |||
| } | |||
|
|
|||
| private static void initSystemRule() { | |||
| SystemRule rule = new SystemRule(); | |||
| SystemRule rule1 = new SystemRule(); | |||
| @@ -0,0 +1,41 @@ | |||
| package com.alibaba.csp.sentinel.slots.system; | |||
There was a problem hiding this comment.
Could you please prepend the license header here?
| @@ -0,0 +1,116 @@ | |||
| package com.alibaba.csp.sentinel.slots.system; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
重构 SystemRule， 参考了 sentinel-golang 对 SystemRule 的实现， 一个系统规则对应一个指标条件
Does this pull request fix one issue?
Fixes #3143 #3084 #3148
Describe how you did it
Describe how to verify it
运行单元测试
运行验证 demo
com.alibaba.csp.sentinel.demo.system.SystemGuardDemo#main()
Special notes for reviews