Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update readme #3029

Merged
merged 1 commit into from
Feb 3, 2023
Merged

doc: update readme #3029

merged 1 commit into from
Feb 3, 2023

Conversation

frank-zsy
Copy link
Contributor

Add contribution leaderboard badge into README file.

Signed-off-by: frank-zsy syzhao1988@126.com

Describe what this PR does / why we need it

Add contribution leaderboard badge into README file.

Does this pull request fix one issue?

NONE

Describe how you did it

NONE

Describe how to verify it

NONE

Special notes for reviews

NONE

Add contribution leaderboard badge into README file.

Signed-off-by: frank-zsy <syzhao1988@126.com>
@sczyh30 sczyh30 added the area/document Category issues or prs related to document. label Feb 3, 2023
@@ -7,6 +7,7 @@
[![Maven Central](https://img.shields.io/maven-central/v/com.alibaba.csp/sentinel-core.svg?label=Maven%20Central)](https://search.maven.org/search?q=g:com.alibaba.csp%20AND%20a:sentinel-core)
[![License](https://img.shields.io/badge/license-Apache%202-4EB1BA.svg)](https://www.apache.org/licenses/LICENSE-2.0.html)
[![Gitter](https://badges.gitter.im/alibaba/Sentinel.svg)](https://gitter.im/alibaba/Sentinel)
[![Leaderboard](https://img.shields.io/badge/Sentinel-Check%20Your%20Contribution-orange)](https://opensource.alibaba.com/contribution_leaderboard/details?projectValue=sentinel)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alibaba%20Sentinel-%20Contribution%20Leaderboard-orange maybe is better than Sentinel-Check%20Your%20Contribution-orange 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but we think Check your contribution may attract more attention from developers since leaderboard is not quite a familiar word to Chinese developer, and for the repos with Chinese documentation, we use 点击查看你的贡献.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 6d6a200 into alibaba:master Feb 3, 2023
@sczyh30
Copy link
Member

sczyh30 commented Feb 3, 2023

Thanks!

@frank-zsy frank-zsy deleted the add-leaderboard-badge branch February 3, 2023 09:50
LearningGp pushed a commit that referenced this pull request Dec 28, 2023
Signed-off-by: frank-zsy <syzhao1988@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/document Category issues or prs related to document.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants