-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for cluster flow control in Sentinel dashboard #302
Conversation
- Update SentinelApiClient to support new-added command APIs - Add controller for cluster config - Add flow controller v2 for global rule pulling / pushing - Extract dynamic rule provider and publisher interface for customized extensions - Add basic cluster config service - Add basic Nacos integration (in test as an example) Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…ashboard Signed-off-by: Eric Zhao <sczyh16@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
===========================================
+ Coverage 38.31% 38.8% +0.49%
- Complexity 932 941 +9
===========================================
Files 219 219
Lines 6921 6921
Branches 939 939
===========================================
+ Hits 2652 2686 +34
+ Misses 3937 3892 -45
- Partials 332 343 +11
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
===========================================
+ Coverage 38.31% 38.8% +0.49%
- Complexity 932 941 +9
===========================================
Files 219 219
Lines 6921 6921
Branches 939 939
===========================================
+ Hits 2652 2686 +34
+ Misses 3937 3892 -45
- Partials 332 343 +11
Continue to review full report at Codecov.
|
Describe what this PR does / why we need it
Add basic support for cluster flow control in Sentinel dashboard
Does this pull request fix one issue?
Related to #200
Describe how you did it
Describe how to verify it
Run the dashboard.
Special notes for reviews
None.