Refactor RateLimitController: improve accuracy and support maxQps threshold > 1000#2951
Merged
sczyh30 merged 2 commits intoalibaba:masterfrom Nov 30, 2022
Merged
Conversation
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
… 1000 * Rename to ThrottlingController * Improve accuracy: use nanoseconds when necessary and support maxQps threshold > 1000 (i.e. wait < 1ms) Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added
kind/enhancement
LearningGp
approved these changes
Nov 30, 2022
|
Math.round(maxCountPerStat) 这里可能出现除零异常，例如 count 设置为 0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Refactor RateLimitController: improve accuracy and support maxQps threshold > 1000.
Does this pull request fix one issue?
Resolves #399, #259
Describe how you did it
RateLimitControllertoThrottlingControllerDescribe how to verify it
Run the test cases and demo.
Special notes for reviews
NOTE: this PR contains breaking change (for public class name).