Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

实现 issue #2935 中的功能 #2936

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

MisterChangRay
Copy link

@MisterChangRay MisterChangRay commented Nov 2, 2022

Describe what this PR does / why we need it

实现 #2935 中的功能

1. dashborad后台变动

  1. 增加MetricsExtRepository接口, 默认继承 MetricsRepository, 可以传递查询参数,方便扩展。

  2. 内存储存实现中增加五分钟统计维度( 使用最近的一个5分整点时间进行统计,如: 12:05,12:10, 12:15...)

内置默认按秒统计过期策略保持不变, 5分钟维度统计数据过期时间默认1天(内存也储存288条数据)

可通过sentinel.dashboard.store.maxMetricLiveTimeOfMin5 配置进行配置过期时间

2. dashborad前端变动

  1. 管理后台增加五分钟维度展示(可切换),
    1667374462478

  2. 增加全局资源统计展示
    可通过异常列,成功列,失败列进行排序
    1667374462471

@sczyh30 sczyh30 added to-review To review area/dashboard Issues or PRs about Sentinel Dashboard kind/feature Category issues or prs related to feature request. labels Nov 3, 2022
@sczyh30 sczyh30 requested a review from cdfive November 3, 2022 08:46
@sczyh30 sczyh30 added this to the 2.0.0 milestone Nov 3, 2022
@sczyh30
Copy link
Member

sczyh30 commented Nov 7, 2022

请参考 CI 错误提示完善代码以遵循阿里巴巴代码规约:https://github.com/alibaba/Sentinel/actions/runs/3384442552/jobs/5668452647

@MisterChangRay
Copy link
Author

请参考 CI 错误提示完善代码以遵循阿里巴巴代码规约:https://github.com/alibaba/Sentinel/actions/runs/3384442552/jobs/5668452647

已跟进并处理

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard kind/feature Category issues or prs related to feature request. to-review To review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants