system rules support ibm J9 #2709
Conversation
|
yanhom seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
sczyh30
added
the
kind/enhancement
| try { | ||
| return method != null ? (long) method.invoke(targetObj) : -1; | ||
| } catch (Exception e) { | ||
| return -1; |
There was a problem hiding this comment.
maybe we need print the exeception?
| try { | ||
| return method != null ? (double) method.invoke(targetObj) : Double.NaN; | ||
| } catch (Exception e) { | ||
| return Double.NaN; |
There was a problem hiding this comment.
maybe we need print the exeception?
| OPERATING_SYSTEM_BEAN_CLASS.cast(OPERATING_SYSTEM_BEAN); | ||
| return OPERATING_SYSTEM_BEAN_CLASS.getDeclaredMethod(name); | ||
| } catch (Exception e) { | ||
| return null; |
There was a problem hiding this comment.
maybe we need print the exeception?
| * com.sun for HotSpot | ||
| */ | ||
| private static final List<String> OPERATING_SYSTEM_BEAN_CLASS_NAMES = Arrays.asList( | ||
| "com.sun.management.OperatingSystemMXBean", "com.ibm.lang.management.OperatingSystemMXBean"); |
There was a problem hiding this comment.
I think write the target class here is not a good way to extends other JVM. cloud you provide a common way to introduce the OperationSystemMXBean?
There was a problem hiding this comment.
The difference only in the bean class name, treat as a common constant, I think there is no need to design a very abstract
|
Can this PR be merged? |
Now system metrics are obtained from com.sun.management.OperatingSystemMXBean for HotSpot JVM, but these are in com.ibm.lang.management.OperatingSystemMXBean for Ibm J9, so need to deduce the target source.