bugfix: Refactor IP verify logic in MachineRegistryController of the dashboard #2694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
added
kind/enhancement
sczyh30
changed the title
Member
|
Nice work. Thanks for contributing! |
|
1.8.4在JDK17环境下仍然报错 |
Contributor
Author
|
1.8.4是 |
回退JDK了🥲 感谢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
修复了在JDK17的环境下
IPAddressUtil报错的问题Does this pull request fix one issue?
Fixes #2691
Describe how you did it
使用
httpclient所提供的工具类org.apache.http.conn.util.InetAddressUtils, 该工具类使用正则的方式校验IP的正确性，不依赖JDK内部实现Describe how to verify it
不再报错
Special notes for reviews
已在本机复现并测试修复的有效性。
以下为JDK17的复现图