refactor：Optimize logging statements using placeholder to avoid unnec… #2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essary concatenation (issue alibaba#1735).
|
|
sczyh30
added
to-review
brotherlu-xcq
requested changes
Apr 28, 2022
Collaborator
brotherlu-xcq
left a comment
brotherlu-xcq
left a comment
There was a problem hiding this comment.
please remove the before , and add indent before ,
...-servlet/src/main/java/com/alibaba/csp/sentinel/adapter/servlet/config/WebServletConfig.java
Outdated
Show resolved
Hide resolved
...rt-common/src/main/java/com/alibaba/csp/sentinel/transport/init/HeartbeatSenderInitFunc.java
Outdated
Show resolved
Hide resolved
...tp/src/main/java/com/alibaba/csp/sentinel/transport/heartbeat/SimpleHttpHeartbeatSender.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/alibaba/csp/sentinel/transport/heartbeat/SpringMvcHttpHeartbeatSender.java
Outdated
Show resolved
Hide resolved
...rt-common/src/main/java/com/alibaba/csp/sentinel/transport/init/HeartbeatSenderInitFunc.java
Outdated
Show resolved
Hide resolved
...ransport-common/src/main/java/com/alibaba/csp/sentinel/transport/config/TransportConfig.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/alibaba/csp/sentinel/datasource/spring/cloud/config/SentinelRuleLocator.java
Outdated
Show resolved
Hide resolved
…essary concatenation (issue alibaba#1735). add indent
Author
|
This issue, I have modified. |
…essary concatenation (issue alibaba#1735). add indent
xiaozzzi
added a commit
to xiaozzzi/Sentinel
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…essary concatenation (issue #1735).
Describe what this PR does / why we need it
for issue #1735
Does this pull request fix one issue?
Fixes #1735
Describe how you did it
use the placeholder {},RecordLog.info()、RecordLog.warn()。
Describe how to verify it
test-unit， check log print
Special notes for reviews
none