Skip to content

Fix param args missing bug in fireExit of StatisticSlot #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tank-zhu
Copy link

fix parameter transfer

fix parameter transfer
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sczyh30
Copy link
Member

sczyh30 commented Sep 15, 2021

Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=2375

@sczyh30 sczyh30 changed the title Update StatisticSlot.java Fix param args missing bug in fireExit of StatisticSlot Sep 15, 2021
@sczyh30 sczyh30 added the kind/bug Category issues or prs related to bug. label Sep 15, 2021
@Tank-zhu
Copy link
Author

解决应用存在有全局异常处理时会导致sentinel的异常数及异常比例的熔断策略失效。

原理:
在全局处理异常前先将异常设置到entry内。
这样sentinel的异常数及异常比例的熔断策略内即可以获取error从而达到熔断机制

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants