CodeClean: remove unused class and test #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sczyh30
approved these changes
Mar 8, 2021
Member
|
Thanks for contributing! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 4, 2021
linkolen
added a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 4, 2021
Remove unused HotParameterLeapArray in param flow control module (alibaba#2070)
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Delete
HotParameterLeapArrayandHotParameterLeapArrayTestclass.Reason: The
HotParameterLeapArrayandHotParameterLeapArrayTestis not used anymore in sentinel. When people review/learn code about param flow limit, they are often confused by these class.If a class/file/code is abandoned we should delete it.
Does this pull request fix one issue?
NONE
Describe how you did it
Delete
HotParameterLeapArrayandHotParameterLeapArrayTestDescribe how to verify it
Special notes for reviews