fix(dashboard): ${user.home} is resolved when maven package #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
${user.home} should be resolve in dashboard runtime, not maven package.
|
|
cdfive
reviewed
Feb 24, 2021
cdfive
added
area/dashboard
cdfive
approved these changes
Feb 24, 2021
Collaborator
cdfive
left a comment
cdfive
left a comment
There was a problem hiding this comment.
LGTM.
According the document the issue referred, the default delimiters are,
<delimiters>
<delimiter>${*}</delimiter>
<delimiter>@</delimiter>
</delimiters>So here need to specify the @ as the only delimiter.
I package it, and get the expected application.properties in the fat jar.
Run the jar, get the expected log file.
It works fine and must be very helpful for users, thanks! @Anilople
sczyh30
approved these changes
Feb 25, 2021
Member
|
Thanks for contributing! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
… dashboard pom (alibaba#2046) `${user.home}` should be resolve in dashboard runtime, not in maven package goal
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 3, 2021
… dashboard pom (alibaba#2046) `${user.home}` should be resolve in dashboard runtime, not in maven package goal
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
… dashboard pom (alibaba#2046) `${user.home}` should be resolve in dashboard runtime, not in maven package goal
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
… dashboard pom (alibaba#2046) `${user.home}` should be resolve in dashboard runtime, not in maven package goal
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 15, 2021
… dashboard pom (alibaba#2046) `${user.home}` should be resolve in dashboard runtime, not in maven package goal
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 16, 2021
… dashboard pom (alibaba#2046) `${user.home}` should be resolve in dashboard runtime, not in maven package goal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
${user.home} in
application.propertiesshould be resolved in dashboard runtime, not after maven package.Does this pull request fix one issue?
Fixes #2045
Describe how you did it
Change maven-resources-plugin's behavior by use delimiter
@Describe how to verify it
Run
mvn clean package -DskipTestson project, then checkBOOT-INF/classes/application.propertiesin filesentinel-dashboard/target/sentinel-dashboard.jarapplication.properties's content is changed.Only
sentinel.dashboard.version=@project.version@is changed to
sentinel.dashboard.version=1.8.2-SNAPSHOTAnd
logging.file=${user.home}/logs/csp/sentinel-dashboard.logkeep same as source code.
Special notes for reviews